From: Andrew Lunn <and...@lunn.ch> Sent: Saturday, May 11, 2019 2:18 AM > On Fri, May 10, 2019 at 08:24:03AM +0000, Andy Duan wrote: > > If MAC address read from nvmem cell and it is valid mac address, > > .of_get_mac_addr_nvmem() add new property "nvmem-mac-address" in > > ethernet node. Once user call .of_get_mac_address() to get MAC address > > again, it can read valid MAC address from device tree in directly. > > I suspect putting the MAC address into OF will go away in a follow up patch. > It > is a bad idea. > > Andrew
I don't know the history why does of_get_mac_addr_nvmem() add the new property "nvmem-mac-address" into OF. But if it already did that, so the patch add the property check in . of_get_mac_address() to avoid multiple read nvmem cells in driver. Andy
