On Fri, 3 May 2019 16:06:55 +0100, Edward Cree wrote: > Introduce a new offload command TC_CLSFLOWER_STATS_BYINDEX, similar to > the existing TC_CLSFLOWER_STATS but specifying an action_index (the > tcfa_index of the action), which is called for each stats-having action > on the rule. Drivers should implement either, but not both, of these > commands. > > Signed-off-by: Edward Cree <ec...@solarflare.com> > --- > include/net/pkt_cls.h | 2 ++ > net/sched/cls_flower.c | 30 ++++++++++++++++++++++++++++++ > 2 files changed, 32 insertions(+)
It feels a little strange to me to call the new stats updates from cls_flower, if we really want to support action sharing correctly. Can RTM_GETACTION not be used to dump actions without dumping the classifiers? If we dump from the classifiers wouldn't that lead to stale stats being returned?
