Brandon Craig Rhodes <[EMAIL PROTECTED]> wrote: > > Egads! You are correct. > > My intention was to preserve the value of "err" if an unsuccessful > value was returned by skb_padto(), and otherwise to return "-1" which > seemed the popular value used for errors elsewhere in the code. > > - Would the expression "err ? err : -1" have served me better? > - Do error codes mean anything here, or should I simply say "return -1"?
err ?: -1 should work. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html