On Fri, 26 Apr 2019 10:47:52 +0200
Paolo Abeni <pab...@redhat.com> wrote:
> Hi,
>
> On Wed, 2019-04-24 at 13:49 -0700, Stephen Hemminger wrote:
> > On Wed, 24 Apr 2019 18:29:39 +0200
> > Paolo Abeni <pab...@redhat.com> wrote:
> >
> > > +static int plug_print_opt(struct qdisc_util *qu, FILE *f, struct rtattr
> > > *opt)
> > > +{
> > > + /* dummy implementation as sch_plug does not implement a dump op */
> > > + return 0;
> > > +}
> > > +
> >
> > All qdisc must dump their state in same form as the parse option.
>
> Thank you for the feedback.
>
> The problem here is that the sch_plug qdisc does not implement the
> dump() qdisc_op, so this callback has nothing to dump.
>
> Must I patch sch_plug first?
>
> Thanks,
>
> Paolo
>
OK, lets put the patch in as is for now. And then fix the kernel, then add
print?
