On Mon, Apr 29, 2019 at 11:49 AM David Laight <david.lai...@aculab.com> wrote:
>
> From: Willem de Bruijn
> > Sent: 29 April 2019 16:47
> > Packet send checks that msg_name is at least sizeof sockaddr_ll.
> > Packet recv must return at least this length, so that its output
> > can be passed unmodified to packet send.
> >
> > This ceased to be true since adding support for lladdr longer than
> > sll_addr. Since, the return value uses true address length.
> >
> > Always return at least sizeof sockaddr_ll, even if address length
> > is shorter. Zero the padding bytes.
> >
> > Change v1->v2: do not overwrite zeroed padding again. use copy_len.
> >
> > Fixes: 0fb375fb9b93 ("[AF_PACKET]: Allow for > 8 byte hardware addresses.")
> > Suggested-by: David Laight <david.lai...@aculab.com>
> > Signed-off-by: Willem de Bruijn <will...@google.com>
> > ---
..
>
> Looks ok to me, not tried to compile it though.Thanks again. I did that and also ran a small recv test that verifies namelen (but clearly did not help me see the stupid bug I made in v1..).
