Re: [PATCH] nl80211: Allocate array of pointers for nla_parse

[Johannes Berg]

On Tue, 2007-01-16 at 11:13 +0100, Marcus Better wrote:
> The code allocates an array of struct nlattr, but it seems to me that it 
> should allocate an array of pointers.
> 
> Signed-off-by: Marcus Better <[EMAIL PROTECTED]>

Yup.
Acked-by: Johannes Berg <[EMAIL PROTECTED]>

> --- a/net/wireless/nl80211.c
> +++ b/net/wireless/nl80211.c
> @@ -843,7 +843,7 @@ static int nl80211_initiate_scan(struct sk_buff *skb, 
> struct genl_info *info)
>  
>               channels = kmalloc(count * sizeof(struct scan_channel),
>                                  GFP_KERNEL);
> -             tb = kmalloc((NL80211_ATTR_MAX+1) * sizeof(struct nlattr),
> +             tb = kmalloc((NL80211_ATTR_MAX+1) * sizeof(struct nlattr *),
>                            GFP_KERNEL);
>  
>               count = 0;

signature.asc
Description: This is a digitally signed message part