On Thu, 25 Apr 2019 18:37:19 +0000, Saeed Mahameed wrote: > On Thu, 2019-04-25 at 09:56 -0700, Jakub Kicinski wrote: > > Currently when CONFIG_TLS_DEVICE is set each time kTLS > > connection is opened and the offload is not successful > > (either because the underlying device doesn't support > > it or e.g. it's tables are full) a rate limited error > > will be printed to the logs. > > > > There is nothing wrong with failing TLS offload. SW > > path will process the packets just fine, avoid the > > noisy messages by demoting them from error to debug > > level. > > > > Signed-off-by: Jakub Kicinski <jakub.kicin...@netronome.com> > > Reviewed-by: Reviewed-by: Simon Horman <simon.hor...@netronome.com> > > Did simon review this patch twice ;) ? > please fixup "Reviewed-by:" Tag.
Ups :) > and also i think it shouldn't be even debug, it should be silent. > The device didn't advertise the feature, why would we print a debug > message on every TLS connection ? Coin toss :) I was wondering if the original author seen some value in those. I have some tls tracepoints queued, those should cover set.
