On Tue, 23 Apr 2019 02:22:49 +0200, Andrew Lunn wrote:
> +/**
> + * module_dsa_tag_drivers() - Helper macro for registering DSA tag
> + * drivers
> + * @__ops_array: Array of tag driver strucutres
> + *
> + * Helper macro for DSA tag drivers which do not do anything special
> + * in module init/exit. Each module may only use this macro once, and
> + * calling it replaces module_init() and module_exit().
> + */
nit: looks like kdoc is misplaced
> +#define dsa_tag_driver_module_drivers(__dsa_tag_drivers_array, __count)
> \
> +static int __init dsa_tag_driver_module_init(void) \
> +{ \
> + dsa_tag_drivers_register(__dsa_tag_drivers_array, __count, \
> + THIS_MODULE); \
nit: THIS_MODULE doesn't align