On Thu, 18 Apr 2019 16:33:22 +0000, Vlad Buslov wrote: > Considering this, I tried to improve my solution to remove possibility > of multiple adds of same filter and it seems to me that it would be > enough to move hw_filters list management in flower offloads functions: > add filter to list while holding rtnl lock in fl_hw_replace_filter() and > remove it from list while holding rtnl lock in fl_hw_destroy_filter(). > What do you think?
Sounds good for now, but I presume the plan is to get rid of rtnl around the driver call.. at which point we would switch to a rwlock? :)