On Tue, Apr 16, 2019 at 11:47 AM <andrii.nakry...@gmail.com> wrote:
>
> From: Andrii Nakryiko <andr...@fb.com>
>
> Using %ld for printing out value of ptrdiff_t type is not portable
> between 32-bit and 64-bit archs. This is causing compilation errors for
> libbpf on 32-bit platform (discovered as part of an effort to integrate
> libbpf into systemd ([0])). Proper formatter is %td, which is used in
> this patch.
>
> v2->v1:
> - add Reported-by
> - provide more context on how this issue was discovered
>
> [0] https://github.com/systemd/systemd/pull/12151
>
> Reported-by: Evgeny Vereshchagin <evv...@ya.ru>
> Cc: Daniel Borkmann <dan...@iogearbox.net>
> Cc: Alexei Starovoitov <a...@fb.com>
> Cc: Yonghong Song <y...@fb.com>
> Signed-off-by: Andrii Nakryiko <andr...@fb.com>
Acked-by: Song Liu <songliubrav...@fb.com>
> ---
> tools/lib/bpf/libbpf.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/lib/bpf/libbpf.c b/tools/lib/bpf/libbpf.c
> index e5b77ad97795..d817bf20f3d6 100644
> --- a/tools/lib/bpf/libbpf.c
> +++ b/tools/lib/bpf/libbpf.c
> @@ -817,7 +817,7 @@ bpf_object__init_internal_map(struct bpf_object *obj,
> struct bpf_map *map,
> memcpy(*data_buff, data->d_buf, data->d_size);
> }
>
> - pr_debug("map %ld is \"%s\"\n", map - obj->maps, map->name);
> + pr_debug("map %td is \"%s\"\n", map - obj->maps, map->name);
> return 0;
> }
>
> --
> 2.17.1
>
