On 16/04/2019 17:28, Roopa Prabhu wrote:
> On Tue, Apr 16, 2019 at 5:38 AM Nikolay Aleksandrov
> <niko...@cumulusnetworks.com> wrote:
>>
>> Hi Stephen,
>> It seems standard (non-json) vlan stats output has been broken since commit:
>> 0f36267485e3 ("bridge: fix vlan show formatting")
>>
>> bridge -s vlan show output before commit 0f36267485e3:
>> port vlan id
>> br0 1 PVID untagged
>> RX: 0 bytes 0 packets
>> TX: 0 bytes 0 packets
>> eth4 1 PVID untagged
>> RX: 0 bytes 0 packets
>> TX: 0 bytes 0 packets
>>
>> bridge -s vlan show output after commit 0f36267485e3:
>> root@debian~/# bridge -s vlan
>> port vlan id
>> br0br0 1 PVID Egress Untagged
>> RX: 0 bytes 0 packets
>> TX: 0 bytes 0 packetseth4eth4 1 PVID Egress
>> Untagged
>> RX: 0 bytes 0 packets
>> TX: 0 bytes 0 packetsroot@debian:~/#
>>
>
> :(. Looks like iproute2 should have selftests too. Its hard to catch
> these in code review.
>
I made a mistake about the commit, the actual culprits are:
45fca4ed9412 ("bridge: fix vlan show stats formatting")
c7c1a1ef51ae ("bridge: colorize output and use JSON print library")
They both broke a different thing about standard stats output:
- 45fca4ed9412 ("bridge: fix vlan show stats formatting")
Added a second print of an interface name (e.g. eth4eth4)
- c7c1a1ef51ae ("bridge: colorize output and use JSON print library")
Broke normal vlan stats output by not printing a new line after them
I'll post a fix in a minute.
