On Fri, Apr 12, 2019 at 9:45 AM Alan Maguire <[email protected]> wrote: > > On Fri, 12 Apr 2019, Willem de Bruijn wrote: > > > From: Willem de Bruijn <[email protected]> > > > > The ENCAP flags in bpf_skb_adjust_room are ignored on decap with > > bpf_skb_net_shrink. Reserve these bits for future use. > > > > Fixes: 868d523535c2d ("bpf: add bpf_skb_adjust_room encap flags") > > Signed-off-by: Willem de Bruijn <[email protected]> > > Reviewed-by: Alan Maguire <[email protected]>
Thanks Alan. > One thought; should we add a line to the growth-only flags in > the description of bpf_skb_adjust_room (ENCAP_L[234]) in bpf.h; > something like: > > "This flag is valid for use with positive len_diff values only." That is easily gleaned from reading the code. I'm not a fan of documentation that duplicates concise readable code. Plus, we'd add it and then remove again before long. We just need to implement the decap behavior. I actually maintain TC ingress decap code in C from that I wrote before eBPF and want to deprecate one day. But it will take some time to do properly.
