On 09/04/2019 12:49, Nikolay Aleksandrov wrote: > On 09/04/2019 12:20, Nikolay Aleksandrov wrote: >> On 09/04/2019 10:36, Huang Rui wrote: >>> If someone setup a bridge and add a port(for example: eth0) >>> into the bridge, but configure the bridge's mtu which is equal >>> to eth0's mtu, the auto tuning flag will not be set true. But [snip] > > Ahh wait, looking again at the change I get why you're doing that. The commit > message is wrong though, you're trying to disable auto-tuning always even > when setting the same MTU, right ? > Or IOW, I guess by the auto-tuning flag you mean BROPT_MTU_SET_BY_USER ? > > I don't like device-specific hacks in the generic code, specifically this > code will not generate an event but will affect state. I don't see a better > approach currently though. > > At the very least please add a better explanation and better subject line. > It is not "auto tuning does not always work", but maybe something similar > to "always disable auto-tuning when the user specified MTU" with details > of the case where setting the same MTU doesn't disable auto-tuning currently. > > Thanks >
One more thing - this has the potential to break setups because a lot of the network configuration software always set the device MTU and will disable the auto-tuning by default with this change. IIRC that was the reason I dropped it from my original change.
