On Mon, Apr 01, 2019 at 02:04:19PM +0200, Toke Høiland-Jørgensen wrote: > Gautam Ramakrishnan <gautamr...@gmail.com> writes: > > > Flow Queue PIE packet scheduler > > > > This patch series implements the Flow Queue Proportional > > Integral Controller (FQ-PIE) active queue management > > algorithm. It is an enhancement over the PIE algorithm. > > It integrates the PIE aqm with a deficit round robin > > scheme. > > > > It is implemented over RFC 8033 aligned version of PIE. > > In this patch, Little's law is used for queue delay > > estimation like PIE. This patch doesn't yet have the > > timestamp based queue delay estimator like freebsd, that > > Dave Taht thinks is better. > > > > We are looking for suggestions on cleanups and > > improvements for this patch. > > Is the fq_ part basically identical to fq_codel? Might make sense to > share some code in that case; might not be a trivial refactoring, > though... > > -Toke
The fq_ part is mostly the same, except for the batch dropping. But the structure of flows are different. Any particular suggestions on the refactoring? -Gautam
