Hi Leandro, Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/Leandro-Dorileo/net-sched-taprio-cbs-Fix-using-invalid-link-speed/20190329-043825 config: alpha-allyesconfig (attached as .config) compiler: alpha-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree GCC_VERSION=7.2.0 make.cross ARCH=alpha All warnings (new ones prefixed by >>): In file included from include/linux/printk.h:330:0, from include/linux/kernel.h:15, from include/linux/list.h:9, from include/linux/module.h:9, from net/sched/sch_cbs.c:58: net/sched/sch_cbs.c: In function 'cbs_set_port_rate': >> net/sched/sch_cbs.c:318:18: warning: format '%lld' expects argument of type >> 'long long int', but argument 5 has type 'long int' [-Wformat=] netdev_dbg(dev, "cbs: set %s's port_rate to: %lld, linkspeed: %d\n", ^ include/linux/dynamic_debug.h:118:15: note: in definition of macro '__dynamic_func_call' func(&id, ##__VA_ARGS__); \ ^~~~~~~~~~~ include/linux/dynamic_debug.h:154:2: note: in expansion of macro '_dynamic_func_call' _dynamic_func_call(fmt, __dynamic_netdev_dbg, \ ^~~~~~~~~~~~~~~~~~ include/linux/netdevice.h:4744:2: note: in expansion of macro 'dynamic_netdev_dbg' dynamic_netdev_dbg(__dev, format, ##args); \ ^~~~~~~~~~~~~~~~~~ >> net/sched/sch_cbs.c:318:2: note: in expansion of macro 'netdev_dbg' netdev_dbg(dev, "cbs: set %s's port_rate to: %lld, linkspeed: %d\n", ^~~~~~~~~~ vim +318 net/sched/sch_cbs.c 307 308 static void cbs_set_port_rate(struct net_device *dev, struct cbs_sched_data *q) 309 { 310 struct ethtool_link_ksettings ecmd; 311 int port_rate = -1; 312 313 if (!__ethtool_get_link_ksettings(dev, &ecmd) && 314 ecmd.base.speed != SPEED_UNKNOWN) 315 port_rate = ecmd.base.speed * 1000 * BYTES_PER_KBIT; 316 317 atomic64_set(&q->port_rate, port_rate); > 318 netdev_dbg(dev, "cbs: set %s's port_rate to: %lld, linkspeed: > %d\n", 319 dev->name, atomic64_read(&q->port_rate), ecmd.base.speed); 320 } 321 --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation
.config.gz
Description: application/gzip
