On 3/27/19 8:29 PM, Alexei Starovoitov wrote:]\ > that was a typo. I meant fib6_flags. > why mess with cfg and use it as weird side effect only to > get rt->fib6_flags = cfg->fc_flags; working after fib6_nh_init() returns? > Why not to move that fib6_flags = fc_flags assignment into fib6_nh_init ? > Then cfg can stay constant and no weird side effects from init function. >
Because fib6_flags is not a nh_init argument and it should not be. I will duplicate that check to appease your request of not touching cfg->flags.
