On 3/27/19 3:46 AM, Ido Schimmel wrote: > On Tue, Mar 26, 2019 at 08:29:42PM -0700, David Ahern wrote: >> From: David Ahern <dsah...@gmail.com> >> >> With fib_nh_common in place, move common initialization and release >> code into helpers used by both ipv4 and ipv6. For the moment, the init >> is just the lwt encap and the release is both the net dev reference and > > s/net dev/netdev/ > >> the the lwt state reference. More will be added later. >> >> Signed-off-by: David Ahern <dsah...@gmail.com> >> --- >> include/net/ip_fib.h | 4 ++++ >> net/ipv4/fib_semantics.c | 60 >> +++++++++++++++++++++++++++++++----------------- > > I don't really mind, but shouldn't the common parts be placed under > net/core/ ? Like how the FIB rules have a common code in > net/core/fib_rules.c ? >
net/core is for common code across networking protocols. Code common between just IPv4 and IPv6 is currently in net/ipv4
