On 3/26/19 9:11 AM, Alexei Starovoitov wrote:
> On Tue, Mar 26, 2019 at 08:19:06AM -0600, David Ahern wrote:
>> work needed. To be able to reach certain clear steps and still maintain
>> the 20'ish patches in a set requirement, I have sent a few patches which
>> are standalone and basically noise - like this one - to avoid
>> distractions on the real change.
>
> This patch is far from noise. In the thread you said that you'll be
> adding 4 more indirect calls and that rings performance alarms.
> retpoline is expensive. If you want to add more indirect calls to fib lookup
> it's no go. Benchmarks with retpoline=off won't show the difference.
>
As I stated in the email I sent ("net: Improve route scalability via
support for nexthop objects"):
"adding hooks to the ipv6 stubs (bump sernum, send route notifications
and delete routes based on nexthop updates)."
Those plus initialization and release of fib6_nh are all done in the
control path.
