On Mon, 25 Mar 2019 13:42:39 +0000
Ioana Ciornei <ioana.cior...@nxp.com> wrote:
> Take advantage of the software Rx batching by using
> netif_receive_skb_list instead of napi_gro_receive.
>
> Signed-off-by: Ioana Ciornei <ioana.cior...@nxp.com>
> ---
Nice to see more people/drivers using: netif_receive_skb_list()
We should likely add a similar napi_gro_receive_list() function.
> drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c | 8 +++++++-
> drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.h | 1 +
> 2 files changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c
> b/drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c
> index 2ba49e9..e923e5c 100644
> --- a/drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c
> +++ b/drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c
> @@ -435,7 +435,7 @@ static void dpaa2_eth_rx(struct dpaa2_eth_priv *priv,
> percpu_stats->rx_packets++;
> percpu_stats->rx_bytes += dpaa2_fd_get_len(fd);
>
> - napi_gro_receive(&ch->napi, skb);
> + list_add_tail(&skb->list, ch->rx_list);
>
> return;
>
> @@ -1108,12 +1108,16 @@ static int dpaa2_eth_poll(struct napi_struct *napi,
> int budget)
> struct dpaa2_eth_fq *fq, *txc_fq = NULL;
> struct netdev_queue *nq;
> int store_cleaned, work_done;
> + struct list_head rx_list;
> int err;
>
> ch = container_of(napi, struct dpaa2_eth_channel, napi);
> ch->xdp.res = 0;
> priv = ch->priv;
>
> + INIT_LIST_HEAD(&rx_list);
> + ch->rx_list = &rx_list;
> +
> do {
> err = pull_channel(ch);
> if (unlikely(err))
> @@ -1157,6 +1161,8 @@ static int dpaa2_eth_poll(struct napi_struct *napi, int
> budget)
> work_done = max(rx_cleaned, 1);
>
> out:
> + netif_receive_skb_list(ch->rx_list);
> +
> if (txc_fq && txc_fq->dq_frames) {
> nq = netdev_get_tx_queue(priv->net_dev, txc_fq->flowid);
> netdev_tx_completed_queue(nq, txc_fq->dq_frames,
> diff --git a/drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.h
> b/drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.h
> index 7879622..a11ebfd 100644
> --- a/drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.h
> +++ b/drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.h
> @@ -334,6 +334,7 @@ struct dpaa2_eth_channel {
> struct dpaa2_eth_ch_stats stats;
> struct dpaa2_eth_ch_xdp xdp;
> struct xdp_rxq_info xdp_rxq;
> + struct list_head *rx_list;
> };
>
> struct dpaa2_eth_dist_fields {
--
Best regards,
Jesper Dangaard Brouer
MSc.CS, Principal Kernel Engineer at Red Hat
LinkedIn: http://www.linkedin.com/in/brouer
