On 3/23/2019 8:23 PM, Vladimir Oltean wrote: > At this moment the following is supported: > * Link state management through phylib Not a show stopper for now, and your implementation looks sane, though I would recommend implementing phylink to be future proof, and especially since you support SGMII. I was not able to review everything deeply so: Acked-by: Florian Fainelli <f.faine...@gmail.com> -- Florian
- Re: [RFC PATCH net-next 02/13] net: dsa: Store v... Florian Fainelli
- [RFC PATCH net-next 05/13] net: dsa: Optional VLAN-ba... Vladimir Oltean
- Re: [RFC PATCH net-next 05/13] net: dsa: Optiona... Florian Fainelli
- [RFC PATCH net-next 01/13] lib: Add support for gener... Vladimir Oltean
- Re: [RFC PATCH net-next 01/13] lib: Add support ... Richard Cochran
- Re: [RFC PATCH net-next 01/13] lib: Add supp... Vladimir Oltean
- Re: [RFC PATCH net-next 01/13] lib: Add ... Richard Cochran
- [RFC PATCH net-next 09/13] net: dsa: sja1105: Add sup... Vladimir Oltean
- Re: [RFC PATCH net-next 09/13] net: dsa: sja1105... Florian Fainelli
- Re: [RFC PATCH net-next 00/13] NXP SJA1105 DSA driver Florian Fainelli
- Re: [RFC PATCH net-next 06/13] net: dsa: Introduce dr... Florian Fainelli
- Re: [RFC PATCH net-next 06/13] net: dsa: Introdu... Vladimir Oltean
- Re: [RFC PATCH net-next 00/13] NXP SJA1105 DSA driver Vinicius Costa Gomes
- Re: [RFC PATCH net-next 00/13] NXP SJA1105 DSA d... Vladimir Oltean