On 03/25/2019 01:50 PM, Willem de Bruijn wrote:
> On Mon, Mar 25, 2019 at 4:48 PM Soheil Hassas Yeganeh <[email protected]>
> wrote:
>>
>> On Mon, Mar 25, 2019 at 4:44 PM Eric Dumazet <[email protected]> wrote:
>>>
>>> My recent patch had at least two problems :
>>>
>>> 1) TX zerocopy wants notification when skb is acknowledged,
>>> thus we need to call skb_zcopy_clear() if the skb is
>>> cached into sk->sk_tx_skb_cache
>>>
>>> 2) Some applications might expect precise EPOLLOUT notifications,
>>> so we need to update sk->sk_wmem_queued and call
>>> sk_mem_uncharge() from sk_wmem_free_skb() in all cases.
>>> The SOCK_QUEUE_SHRUNK flag must also be set.
>>>
>>> Fixes: 472c2e07eef0 ("tcp: add one skb cache for tx")
>>> Signed-off-by: Eric Dumazet <[email protected]>
>>> Cc: Willem de Bruijn <[email protected]>
>>> Cc: Soheil Hassas Yeganeh <[email protected]>
>>
>> Acked-by: Soheil Hassas Yeganeh <[email protected]>
>
> Acked-by: Willem de Bruijn <[email protected]>
>
Thanks Soheil and Willem
I will send a v2, because I missed the needed changes in tcp_write_queue_purge()
