On Sat, 23 Mar 2019 23:47:50 +0100, Jiri Pirko wrote: > >type setting. I'd rather those calls happened on fully initialized > >netdev (and port), could you perhaps just take this patch into the > > I don't get it, you are commenting cleanup part. On init, the type set > happens on fully initialized devlink_port and netdev.
I'm talking about internal nfp API calls, nfp_app_vnic_init() and nfp_app_vnic_clean() should be called while vNIC is completely initialized and registered from stack's PoV. netdev, and devlink port fully initialized and set up. I don't think it matters much, just an imperfection.
