On 3/22/2019 3:24 PM, David Miller wrote:
> From: Boris Pismenny <bor...@mellanox.com>
> Date: Thu, 21 Mar 2019 16:29:02 +0200
> 
>> User applications are forced to define the SOL_TLS manually at the
>> moment, which is inappropriate. Add SOL_TLS to the uapi.
>>
>> Other protocols handle this similarly. For example see SOL_TIPC.
>>
>> Signed-off-by: Boris Pismenny <bor...@mellanox.com>
>> ---
>> v1: update commit message
> 
> Where did this convention come from where we define SOL_* in
> linux/socket.h and then have to do this ifdef dance in the per-family
> UAPI header?
> 

The source for this is not known to me.
I've saw that this issue was mentioned and fixed in libc:
http://sourceware.org/ml/libc-alpha/2016-05/msg00322.html

> AF_ALG and AF_KCM never did this, but I see that AF_TIPC did.
> 
> There really has to be a better way.
> 

Maybe libc maintainers need to be notified whenever linux/socket.h is 
modified.

Reply via email to