From: Rosen Penev <ros...@gmail.com> Date: Tue, 19 Mar 2019 13:53:40 -0700
> It allows some of the code to be simplified. ... > @@ -4641,9 +4640,6 @@ static int mvneta_probe(struct platform_device *pdev) > phylink_destroy(pp->phylink); > err_free_irq: > irq_dispose_mapping(dev->irq); > -err_free_netdev: > - free_netdev(dev); > - return err; It would be great if the code was compile tested too. You're removing the error return the err_free_irq: path needs.
