On 17.03.2019 16:41, VDR User wrote:
> A quick comment on patch 1:
>
>> @@ -1294,6 +1295,7 @@ static void rtl_ack_events(struct rtl8169_private *tp,
>> u16 bits)
>> static void rtl_irq_disable(struct rtl8169_private *tp)
>> {
>> RTL_W16(tp, IntrMask, 0);
>> + tp->irq_enabled = 0;
>> }
>
> This function is slightly different in the vanilla 5.0 driver:
>
Right, the patch is based on latest linux-next.
> static void rtl_irq_disable(struct rtl8169_private *tp)
> {
> RTL_W16(tp, IntrMask, 0);
> mmiowb();
> }
>
> Unless that mmiowb() matters, I'll continue.
>
No, it doesn't matter.
> Derek
>
Heiner
