Em Fri, Mar 15, 2019 at 12:16:32PM -0700, Jakub Kicinski escreveu:
> Please do keep the current model of name val, IOW dump map *name* pids..

I don't have a problem with that, but what would be the problem with
supporting both:

  bpftool map dump name pids_filtered

and:

  bpftool map dump pids_filtered

And for that matter, even:

  bpftool map dump id 30

And

  bpftool map dump 30

Ditto for 'pinned'?

I.e. less typing, the tool can be smart enough to figure out what is
that is being asked, i.e. is it a number? Try first it as an 'id', etc.

- Arnaldo
 
> >   [{
> >           "key": 26554,
> >           "value": true
> >       },{
> >           "key": 2592,
> >           "value": true
> >       }
> >   ]
> >   #
> > 
> > Cc: Alexei Starovoitov <[email protected]>
> > Cc: Daniel Borkmann <[email protected]>
> > Cc: Jakub Kicinski <[email protected]>
> > cc: Jiri Olsa <[email protected]>
> > Cc: Martin KaFai Lau <[email protected]>
> > Cc: Namhyung Kim <[email protected]>
> > Cc: Peter Zijlstra <[email protected]>
> > Cc: Quentin Monnet <[email protected]>
> > Cc: Song Liu <[email protected]>
> > Cc: Stanislav Fomichev <[email protected]>
> > Cc: Yonghong Song <[email protected]>
> > Link: https://lkml.kernel.org/n/[email protected]
> > Signed-off-by: Arnaldo Carvalho de Melo <[email protected]>
> 
> Please also update the bash completions and all the help/mans/docs.

-- 

- Arnaldo

Reply via email to