> -----Original Message----- > From: Harini Katakam [mailto:hari...@xilinx.com] > Sent: Tuesday, March 12, 2019 10:40 PM > To: Paul Thomas <pthomas8...@gmail.com> > Cc: Keller, Jacob E <jacob.e.kel...@intel.com>; netdev@vger.kernel.org > Subject: Re: [PATCH] Check for SKBTX_HW_TSTAMP in macb driver > > Hi Paul, Jake, > On Wed, Mar 13, 2019 at 5:01 AM Paul Thomas <pthomas8...@gmail.com> wrote: > > > > On Tue, Mar 12, 2019 at 7:07 PM Keller, Jacob E > > <jacob.e.kel...@intel.com> wrote: > > > > > > > > > > > > > -----Original Message----- > > > > From: Paul Thomas [mailto:pthomas8...@gmail.com] > > > > Sent: Tuesday, March 12, 2019 3:05 PM > > > > To: Keller, Jacob E <jacob.e.kel...@intel.com> > > > > Cc: netdev@vger.kernel.org > > > > Subject: Re: [PATCH] Check for SKBTX_HW_TSTAMP in macb driver > > > > > > > > Hi Jake, thanks for all the help and for looking at this! > > > > > > > > > > > > > > You have two conditionals inside, and I misread where you were doing > > > > > the > checking > > > > of the SKBTX_HW_TSTAMP flag. > > > > > > > > > > I would do the following : > > > > > > > > > > if (unlikely(skb_shinfo(skb)->tx_flags & SKBTX_HWTSTAMP) && > > > > > gem_ptp_do_txstamp(queue, skb, desc)) { > > Thanks for looking into this. Shouldn't this be: > if (unlikely(skb_shinfo(skb)->tx_flags & SKBTX_HWTSTAMP) && > (gem_ptp_do_txstamp(queue, skb, desc) == 0)) { > > Regards, > Harini
Yes, you're correct, because gem_ptp_do_txstamp doesn't use the "non-zero = error code" pattern. Thanks, Jake
