From: Kangjie Lu <k...@umn.edu> Date: Sun, 10 Mar 2019 03:14:53 -0500
> In case ioremap fails, the fix returns to avoid NULL pointer > dereferences. > > Signed-off-by: Kangjie Lu <k...@umn.edu> > --- > drivers/net/ethernet/8390/pcnet_cs.c | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/drivers/net/ethernet/8390/pcnet_cs.c > b/drivers/net/ethernet/8390/pcnet_cs.c > index 61e43802b9a5..d82ecedf7366 100644 > --- a/drivers/net/ethernet/8390/pcnet_cs.c > +++ b/drivers/net/ethernet/8390/pcnet_cs.c > @@ -289,6 +289,9 @@ static struct hw_info *get_hwinfo(struct pcmcia_device > *link) > > virt = ioremap(link->resource[2]->start, > resource_size(link->resource[2])); > + if (unlikely(!virt)) > + return NULL; Please retain the existing indentation, otherwise your changes are impossible to read.