On 03/08/2019 07:40 AM, Stefano Brivio wrote:
> If we receive a packet while deleting a VXLAN device, there's a chance
> vxlan_rcv() is called at the same time as vxlan_dellink(). This is fine,
> except that vxlan_dellink() should never ever touch stuff that's still in
> use, such as the GRO cells list.
>
> Otherwise, vxlan_rcv() crashes while queueing packets via
> gro_cells_receive().
>
> Move the gro_cells_destroy() to vxlan_uninit(), which runs after the RCU
> grace period is elapsed and nothing needs the gro_cells anymore.
>
> This is now done in the same way as commit 8e816df87997 ("geneve: Use GRO
> cells infrastructure.") originally implemented for GENEVE.
>
> Reported-by: Jianlin Shi <ji...@redhat.com>
> Fixes: 58ce31cca1ff ("vxlan: GRO support at tunnel layer")
> Signed-off-by: Stefano Brivio <sbri...@redhat.com>
> Reviewed-by: Sabrina Dubroca <s...@queasysnail.net>
Nice catch, thanks.
Reviewed-by: Eric Dumazet <eduma...@google.com>
