On 02.03.2019 21:13, Andrew Lunn wrote: > On Sat, Mar 02, 2019 at 04:57:32PM +0100, Heiner Kallweit wrote: >> Propagate the external PHY settings also in 1000BaseX and >> 2500BaseX mode. > > Hi Heiner > Hi Andrew
> I don't think this is needed. 1000BaseX and 2500BaseX does not support > inband signalling. So the mac_config() call for these modes should > include the needed speed configuration. I've used 1000BaseX with an > SFP and there was no need to configure anything. > 1000BaseX and 2500BaseX use 802.3z Clause 37 inband auto-neg. From what I've read 1000BaseT is an extension of it. My understanding is that w/o such inband signalling we had no chance to detect a "link up" situation. All we could detect is: serial connection is synced. Also my understanding is that the ACK to this inband signalling triggers the "link up" interrupt. Here I found something: http://www.methode.com/Documents/TechnicalLibrary/SFP_Ethernet_Auto_Negotiation.pdf I briefly looked at the SFP connector and there don't seem to be pins for out-of-band signalling. So there must be some inband signalling. > Andrew > Heiner