From: Li RongQing <lirongq...@baidu.com>

Empty case is fine and does not switch fall-through

Signed-off-by: Li RongQing <lirongq...@baidu.com>
Signed-off-by: Pablo Neira Ayuso <pa...@netfilter.org>
---
 net/netfilter/nf_nat_core.c    | 2 +-
 net/netfilter/nf_tables_core.c | 1 -
 2 files changed, 1 insertion(+), 2 deletions(-)

diff --git a/net/netfilter/nf_nat_core.c b/net/netfilter/nf_nat_core.c
index 11acd7367623..af7dc6537758 100644
--- a/net/netfilter/nf_nat_core.c
+++ b/net/netfilter/nf_nat_core.c
@@ -240,7 +240,7 @@ static bool l4proto_in_range(const struct 
nf_conntrack_tuple *tuple,
        __be16 port;
 
        switch (tuple->dst.protonum) {
-       case IPPROTO_ICMP: /* fallthrough */
+       case IPPROTO_ICMP:
        case IPPROTO_ICMPV6:
                return ntohs(tuple->src.u.icmp.id) >= ntohs(min->icmp.id) &&
                       ntohs(tuple->src.u.icmp.id) <= ntohs(max->icmp.id);
diff --git a/net/netfilter/nf_tables_core.c b/net/netfilter/nf_tables_core.c
index 2a00aef7b6d4..e56a94dff34e 100644
--- a/net/netfilter/nf_tables_core.c
+++ b/net/netfilter/nf_tables_core.c
@@ -221,7 +221,6 @@ nft_do_chain(struct nft_pktinfo *pkt, void *priv)
                chain = regs.verdict.chain;
                goto do_chain;
        case NFT_CONTINUE:
-               /* fall through */
        case NFT_RETURN:
                nft_trace_packet(&info, chain, rule,
                                 NFT_TRACETYPE_RETURN);
-- 
2.11.0


Reply via email to