Hi Toke,

I love your patch! Perhaps something to improve:

[auto build test WARNING on net-next/master]

url:    
https://github.com/0day-ci/linux/commits/Toke-H-iland-J-rgensen/xdp-Use-a-default-map-for-xdp_redirect-helper/20190301-021039
config: x86_64-randconfig-l2-02281415 (attached as .config)
compiler: gcc-5 (Debian 5.5.0-3) 5.4.1 20171010
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

All warnings (new ones prefixed by >>):

   In file included from include/linux/bpf-cgroup.h:5:0,
                    from include/linux/cgroup-defs.h:22,
                    from include/linux/cgroup.h:28,
                    from include/net/netprio_cgroup.h:17,
                    from include/linux/netdevice.h:46,
                    from drivers//tty/synclinkmp.c:55:
   include/linux/bpf.h: In function 'dev_map_inc_redirect_count':
   include/linux/bpf.h:731:1: warning: no return statement in function 
returning non-void [-Wreturn-type]
    }
    ^
   include/linux/bpf.h: At top level:
>> include/linux/bpf.h:738:13: warning: 'struct bpf_dtab_netdev' declared 
>> inside parameter list
         struct bpf_dtab_netdev *dst)
                ^
>> include/linux/bpf.h:738:13: warning: its scope is only this definition or 
>> declaration, which is probably not what you want

vim +738 include/linux/bpf.h

   728  
   729  static inline int dev_map_inc_redirect_count(void)
   730  {
 > 731  }
   732  
   733  static inline void dev_map_dec_redirect_count(void)
   734  {
   735  }
   736  
   737  static inline void __dev_map_insert_ctx(struct bpf_map *map,
 > 738                                          struct bpf_dtab_netdev *dst)
   739  {
   740  }
   741  

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Attachment: .config.gz
Description: application/gzip

Reply via email to