On Tue, Feb 26, 2019 at 9:45 AM Petr Machata <pe...@mellanox.com> wrote: > > > Roopa Prabhu <ro...@cumulusnetworks.com> writes: > > > On Tue, Feb 26, 2019 at 5:51 AM Petr Machata <pe...@mellanox.com> wrote: > >> > >> Many of the flags for which you call this don't actually have the else > >> branch. However I suspect there are no good reasons not to allow > >> resetting a flag. > >> > >> Reviewed-by: Petr Machata <pe...@mellanox.com> > > > > yes, correct, that was intentional. > > also, I am not sure what is the best way to support reseting of a NLA_FLAG. > > Absence of the flag attribute in the request cannot be the reason for > > resetting or clearing the flag. > > Yeah, I was thinking about that. It looks like this would need a new set > of u8 attributes :-(
yes, and thats unfortunate. We should keep an eye on future NLA_FLAG attributes during review .
