On 25/02/2019 12:40, xiangxia.m....@gmail.com wrote: > From: Tonghao Zhang <xiangxia.m....@gmail.com> > > The encapsulation is not supported for mlx5 VFs. When we try to > offload that action, the -EINVAL is returned, but not -EOPNOTSUPP. > This patch changes the returned value and ignore to confuse user. > > For example: (p2p1_0 is VF net device) > tc filter add dev p2p1_0 protocol ip parent ffff: prio 1 flower skip_sw \ > src_mac e4:11:22:33:44:01 \ > action tunnel_key set \ > src_ip 1.1.1.100 \ > dst_ip 1.1.1.200 \ > dst_port 4789 id 100 \ > action mirred egress redirect dev vxlan0 > > "RTNETLINK answers: Invalid argument" > > Signed-off-by: Tonghao Zhang <xiangxia.m....@gmail.com> > --- > drivers/net/ethernet/mellanox/mlx5/core/en_tc.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c > b/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c > index d9fcb14..f5029ea 100644 > --- a/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c > +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c > @@ -2302,7 +2302,8 @@ static int parse_tc_nic_actions(struct mlx5e_priv *priv, > } > break; > default: > - return -EINVAL; > + NL_SET_ERR_MSG_MOD(extack, "The offload action is not > supported"); > + return -EOPNOTSUPP; > } > } > > @@ -2624,7 +2625,8 @@ static int parse_tc_fdb_actions(struct mlx5e_priv *priv, > break; > } > default: > - return -EINVAL; > + NL_SET_ERR_MSG_MOD(extack, "The offload action is not > supported"); > + return -EOPNOTSUPP; > } > } > >
Reviewed-by: Roi Dayan <r...@mellanox.com>
