Re: [PATCH v2 iproute2-next 04/11] devlink: Add helper functions for name and value separately

[Aya Levin]

On 2/21/2019 4:08 PM, Jiri Pirko wrote:
> Thu, Feb 21, 2019 at 02:42:40PM CET, a...@mellanox.com wrote:
>> Add a new helper functions which outputs only values (without name
>> label) for different types: boolean, uint, uint64, string and binary.
>> In addition add a helper function which prints only the name label.
>>
>> Signed-off-by: Aya Levin <a...@mellanox.com>
>> Reviewed-by: Moshe Shemesh <mo...@mellanox.com>
>> ---
>> devlink/devlink.c | 66 
>> ++++++++++++++++++++++++++++++++++++++++++++++++++++++-
>> 1 file changed, 65 insertions(+), 1 deletion(-)
>>
>> diff --git a/devlink/devlink.c b/devlink/devlink.c
>> index b073ae020d52..5d69c4f24f29 100644
>> --- a/devlink/devlink.c
>> +++ b/devlink/devlink.c
>> @@ -1588,7 +1588,6 @@ static void pr_out_port_handle_end(struct dl *dl)
>>              pr_out("\n");
>> }
>>
>> -
> 
> Please avoid changes like this.
Thanks,
Will fix in next version
> 
> 
> [...]
>