On Tue, 19 Feb 2019 10:19:42 +0100, Jiri Pirko wrote:
> Fri, Feb 15, 2019 at 04:44:29PM CET, jakub.kicin...@netronome.com wrote:
> >On Fri, 15 Feb 2019 11:15:14 +0100, Jiri Pirko wrote:
> >> > static const struct ethtool_ops nfp_net_ethtool_ops = {
> >>
> >> Why don't you use the compat fallback? I think you should.
> >
> >You and Michal both asked the same so let me answer the first to ask :)
> >- if devlink is built as a module the fallback is not reachable.
>
> So the fallback is not really good as you can't use it for real drivers
> anyway. Odd. Maybe we should compile devlink in without possibility to
> have it as module.
Ack, I'll make devlink a bool.
I need a little extra time, I forgot that nfp's flower offload still
doesn't register all ports (using your port flavour infrastructure).
