On Wed, Feb 13, 2019 at 11:47 PM Vlad Buslov <vla...@mellanox.com> wrote: > > Without rtnl lock protection tcf proto can be deleted concurrently. Check > tcf proto 'deleting' flag after taking tcf spinlock to verify that no > concurrent deletion is in progress. Return EAGAIN error if concurrent > deletion detected, which will cause caller to retry and possibly create new > instance of tcf proto. >
Please state the reason why you prefer retry over locking the whole tp without retrying, that is why and how it is better? Personally I always prefer non-retry logic, because it is very easy to understand and justify its correctness. As you prefer otherwise, please share your reasoning in changelog. Thanks!
