Hi, On Sat, 16 Feb 2019 20:10:24 +0100 Heiner Kallweit <hkallwe...@gmail.com> wrote:
> When genphy_c45_pma_setup_forced() is called the "aneg enabled" bit may > still be set, therefore clear it. This is also in line with what > genphy_setup_forced() does for Clause 22. > > Signed-off-by: Heiner Kallweit <hkallwe...@gmail.com> > --- > drivers/net/phy/phy-c45.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/net/phy/phy-c45.c b/drivers/net/phy/phy-c45.c > index bef126344..0374c50b1 100644 > --- a/drivers/net/phy/phy-c45.c > +++ b/drivers/net/phy/phy-c45.c > @@ -71,6 +71,10 @@ int genphy_c45_pma_setup_forced(struct phy_device *phydev) > return ret; > > return phy_write_mmd(phydev, MDIO_MMD_PMAPMD, MDIO_CTRL2, ctrl2); > + if (ret < 0) Perhaps you meant ret = phy_write_mmd(...)? > + return ret; > + > + return genphy_c45_an_disable_aneg(phydev); > } > EXPORT_SYMBOL_GPL(genphy_c45_pma_setup_forced); > -- Stefano
