Re: [PATCH net-next v2 3/3] enetc: Add ENETC PF level external MDIO support

[Andrew Lunn]

On Fri, Feb 15, 2019 at 12:10:14PM +0200, Claudiu Manoil wrote:
> Each ENETC PF has its own MDIO interface, the corresponding
> MDIO registers are mapped in the ENETC's Port register block.
> The current patch adds a driver for these PF level MDIO buses,
> so that each PF can manage directly its own external link.
> 
> Signed-off-by: Alex Marginean <alexandru.margin...@nxp.com>
> Signed-off-by: Claudiu Manoil <claudiu.man...@nxp.com>
> ---
> v2 - used readx_poll_timeout()
>    - added mdio node child to the port node

Hi Claudiu

Please document this in the device tree binding.

> +     /* return all Fs if nothing was there */
> +     if (enetc_rd_reg(&regs->mdio_cfg) & MDIO_CFG_RD_ER) {
> +             dev_err(&bus->dev,
> +                     "Error while reading PHY%d reg at %d.%hhu\n",
> +                     phy_id, dev_addr, regnum);
> +             return 0xffff;

I'm not sure you want a dev_err() here. The device tree binding allows
you to have a phy node without a reg value. When that happens, the
core code will scan all 32 addresses to find the PHY. This is going to
spam the log. dev_dbg() might be better.

     Andrew