On Wed, Feb 13, 2019 at 1:57 PM Stephen Hemminger <step...@networkplumber.org> wrote: > > On Tue, 12 Feb 2019 17:58:41 -0800 > Eric Dumazet <eduma...@google.com> wrote: > > > In the past, we tried to increase the buffer size up to 32 KB in order > > to reduce number of syscalls per dump. > > > > Commit 2d34851cd341 ("lib/libnetlink: re malloc buff if size is not enough") > > brought the size back to 4KB because the kernel can not know the application > > is ready to receive bigger requests. > > > > See kernel commits 9063e21fb026 ("netlink: autosize skb lengthes") and > > d35c99ff77ec ("netlink: do not enter direct reclaim from netlink_dump()") > > for more details. > > > > Fixes: 2d34851cd341 ("lib/libnetlink: re malloc buff if size is not enough") > > Signed-off-by: Eric Dumazet <eduma...@google.com> > > Cc: Hangbin Liu <liuhang...@gmail.com> > > Cc: Phil Sutter <p...@nwl.cc> > > Applied, although maybe we should bump it to 64K or bigger?
Note the kernel does not yet try 64KB allocations, so I do not see an urgent need for that :)