Re: [PATCH for-next 4/4] devlink: add health command support

[Stephen Hemminger]

On Sun, 10 Feb 2019 20:28:49 +0200
Aya Levin <a...@mellanox.com> wrote:

> +
> +static void cmd_health_help(void)
> +{
> +     pr_err("Usage: devlink health show [ dev DEV reporter REPORTER_NAME 
> ]\n");
> +     pr_err("Usage: devlink health recover DEV reporter REPORTER_NAME\n");
> +     pr_err("Usage: devlink health diagnose DEV reporter REPORTER_NAME\n");
> +     pr_err("Usage: devlink health dump show DEV reporter REPORTER_NAME\n");
> +     pr_err("Usage: devlink health dump clear DEV reporter REPORTER_NAME\n");
> +     pr_err("Usage: devlink health set DEV reporter REPORTER_NAME NAME 
> VALUE\n");
> +}
> +

Minor nit:
I prefer that all code and outputs in iproute2 look the same for ease
of maintenance and constituency of user experience.

Why does devlink not use:

static void cmd_health_help(void)
{
        fprintf(stderr, "Usage: devlink health show [ dev DEV reporter 
REPORTER_NAME ]\n");
        fprintf(stderr, "       devlink health recover DEV reporter 
REPORTER_NAME\n");
        fprintf(stderr, "       devlink health diagnose DEV reporter 
REPORTER_NAME\n");

...

Or 
        fprintf(stderr, "Usage: devlink health show [ dev DEV reporter 
REPORTER_NAME ]\n"
                        "       devlink health recover DEV reporter 
REPORTER_NAME\n"    
                        "       devlink health diagnose DEV reporter 
REPORTER_NAME\n");