On Sat, Feb 09, 2019 at 03:24:47PM +0100, Heiner Kallweit wrote: > From: Andrew Lunn <and...@lunn.ch> > Add support for runtime determination of what the PHY supports, by > adding a new function to the phy driver. The get_features call should > set the phydev->supported member with the features the PHY supports. > It is only called if phydrv->features is NULL. > > This requires minor changes to pause. The PHY driver should not set > pause abilities, except for when it has odd cause capabilities, e.g. > pause cannot be disabled. With this change, phydev->supported already > contains the drivers abilities, including pause. So rather than > considering phydrv->features, look at the phydev->supported, and > enable pause if neither of the pause bits are already set.
Hi Heiner Ah, cool, these are the patches i was asking for, when you asked about splitting Maxime's patches. There is one more in my tree which converts the marvell10g to using this. I think that should be posted as well. It makes it clear how this should be used, and it replaces one of the patches in Maxime's set. > Signed-off-by: Andrew Lunn <and...@lunn.ch> > [hkallwe...@gmail.com: fixed small checkpatch complaint in one comment] Thanks. Andrew