On Fri, 8 Feb 2019 11:32:14 +0000, Sudarsana Reddy Kalluru wrote: > >On Thu, 7 Feb 2019 06:20:10 -0800, Sudarsana Reddy Kalluru wrote: > >> SmartAN feature detects the peer/cable capabilities and establishes > >> the link in the best possible configuration. > > > >It sounds familiar, I need to check with FW team, but I think we may be doing > >a similar thing, and adding a common API rather than ethtool flag would be > >preferable. > > > >Could you please share a little bit more detail? What are the configurations > >this would choose between? > > Jakub, > Following doc provides detailed information on this feature. We simply need > a flag to display whether the feature is enabled in the hardware or not, > hence adding it to "ethtool --show-priv-flags". > https://www.cavium.com/Dell/Documents/Converged/TB_Establishing_Adaptive_Links_with_SmartAN_Dell.pdf
Thanks! Yes, that's exactly the same thing. In a nutshell trying different serdes and FEC speeds. I guess I'll just put adding an API for this down as a TODO, and add it once we have ethtool netlink. And keep IOCTL ethtool frozen until then. So I think the priv flag is fine for now.
