On 2/8/2019 9:59 AM, Simon Horman wrote: > On Mon, Feb 04, 2019 at 12:09:00PM -0800, David Miller wrote: >> From: Gregory Rose <gvrose8...@gmail.com> >> Date: Mon, 4 Feb 2019 11:41:29 -0800 >> >>> On 2/3/2019 1:12 AM, Eli Britstein wrote: >>>> Declare ovs key structures using macros as a pre-step towards to >>>> enable retrieving fields information, as a work done in proposed >>>> commit in the OVS tree https://patchwork.ozlabs.org/patch/1023406/ >>>> ("odp-util: Do not rewrite fields with the same values as matched"), >>>> with no functional change. >>>> >>>> Signed-off-by: Eli Britstein <el...@mellanox.com> >>>> Reviewed-by: Roi Dayan <r...@mellanox.com> >>> Obscuring the structures with these macros is awful. I'm opposed but >>> I see it has already been >>> accepted upstream so I guess that's that. >> I am personally in no way obligated to apply this patch to my tree >> just because "upstream" did, and I absolutely have no plans to do so >> at this point. >> >> This patch is absolutely awful. > I hate to jump on a bandwagon, but this patch makes the code much > less readable.
Please review the alternative I have posted: https://mail.openvswitch.org/pipermail/ovs-dev/2019-February/356000.html
