Re: [PATCH net-next v2 07/10] net: phy: marvell10g: Add support for 2.5GBASET

[Andrew Lunn]

>               if (phydev->speed == SPEED_10000)
>                       phydev->interface = PHY_INTERFACE_MODE_10GKR;
> +             else if (phydev->speed == SPEED_2500)
> +                     phydev->interface = PHY_INTERFACE_MODE_2500BASEX;
>               else if (phydev->speed >= SPEED_10 &&
> -                      phydev->speed < SPEED_10000)
> +                      phydev->speed < SPEED_2500)
>                       phydev->interface = PHY_INTERFACE_MODE_SGMII;
>       }

Maybe swap to a switch statement?

>  static struct phy_driver mv3310_drivers[] = {
>       {
> -             .phy_id         = 0x002b09aa,
> +             .phy_id         = MARVELL_PHY_ID_88X3310,

What does the datasheet say about the lower nibble? Often it is a
silicon revision field, so you don't match on it. But 0xa is a rather
odd revision.

Thanks
        Andrew