Hi Peter,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on bpf-next/master]

url:    
https://github.com/0day-ci/linux/commits/Peter-Oskolkov/bpf-add-BPF_LWT_ENCAP_IP-option-to-bpf_lwt_push_encap/20190207-205725
base:   https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git master
config: i386-defconfig (attached as .config)
compiler: gcc-8 (Debian 8.2.0-14) 8.2.0
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

All errors (new ones prefixed by >>):

   net//core/filter.c: In function 'bpf_push_ip_encap':
>> net//core/filter.c:4808:9: error: implicit declaration of function 
>> 'bpf_lwt_push_ip_encap'; did you mean 'bpf_push_ip_encap'? 
>> [-Werror=implicit-function-declaration]
     return bpf_lwt_push_ip_encap(skb, hdr, len, ingress);
            ^~~~~~~~~~~~~~~~~~~~~
            bpf_push_ip_encap
   At top level:
   net//core/filter.c:4805:12: warning: 'bpf_push_ip_encap' defined but not 
used [-Wunused-function]
    static int bpf_push_ip_encap(struct sk_buff *skb, void *hdr, u32 len,
               ^~~~~~~~~~~~~~~~~
   cc1: some warnings being treated as errors

vim +4808 net//core/filter.c

  4804  
  4805  static int bpf_push_ip_encap(struct sk_buff *skb, void *hdr, u32 len,
  4806                               bool ingress)
  4807  {
> 4808          return bpf_lwt_push_ip_encap(skb, hdr, len, ingress);
  4809  }
  4810  

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Attachment: .config.gz
Description: application/gzip

Reply via email to