Re: [PATCH] net: stmmac: Variable "val" in function sun8i_dwmac_set_syscon() could be uninitialized

[David Miller]

From: Yizhuo <yzhai...@ucr.edu>
Date: Tue,  5 Feb 2019 14:15:59 -0800

> @@ -639,9 +639,14 @@ static int sun8i_dwmac_set_syscon(struct stmmac_priv 
> *priv)
>       struct sunxi_priv_data *gmac = priv->plat->bsp_priv;
>       struct device_node *node = priv->device->of_node;
>       int ret;
> -     u32 reg, val;
> +     u32 reg, val = 0;
> +
> +     ret = regmap_read(gmac->regmap, SYSCON_EMAC_REG, &val);
> +     if (ret) {
> +             dev_err(priv->device, "Fail to read SYSCON_EMAC_REG.\n");
> +             return ret;
> +     }

I agree with the other reviewer that since you check 'ret' the initialization of
'val' is no longer needed.