On Wed, Feb 6, 2019 at 4:53 PM Cong Wang <xiyou.wangc...@gmail.com> wrote: > > On Wed, Feb 6, 2019 at 4:28 PM Eric Dumazet <eric.duma...@gmail.com> wrote: > > > > > > > > On 02/06/2019 04:04 PM, Cong Wang wrote: > > > > > synchronize_irq() is called before mlx5_cq_put(), so I don't > > > see why readers could get 0 refcnt. > > > > Then the more reasons to get rid of the refcount increment/decrement > > completely ... > > > > Technically, even the rcu_read_lock() and rcu_read_unlock() are not needed, > > since synchronize_irq() is enough. > > Excellent point. > > For the refcnt, I am afraid we still have to hold refcnt for the tasklet, > mlx5_cq_tasklet_cb. But yeah, should be safe to remove from IRQ > path.
the tasklet path is for rdma CQs only, netdev cqs handling will be refcnt free.
