At 2019-02-06 03:57:34, "Maciej W. Rozycki" <ma...@linux-mips.org> wrote: >On Wed, 6 Feb 2019, Yang Wei wrote: > >Reviewed-by: Maciej W. Rozycki <ma...@linux-mips.org> > > It looks to me the driver has to be reviewed WRT `dev_kfree_skb' vs >`kfree_skb' use too. I'll have a look into it unless you are happy to do >that. > > Thanks for your contribution! > Hi, Maciej
I think kfree_skb() should be called when skb is dropped by network drivers. I found that many network drivers have such problems that not use kfree_skb/consume_skb properly. Maybe because 'drop profiles' appears later than many network drivers? The problem 'dev_kfree_skb' vs 'kfree_skb' should be fixed. I think that is lower priority than the current patch. Network driver should not perturb drop profiles when skb successful xmit. Thanks Yang
