On 2/5/19 2:53 PM, Stephen Hemminger wrote: > On Thu, 31 Jan 2019 18:58:09 +0100 > Davide Caratti <dcara...@redhat.com> wrote: > >> + print_uint(PRINT_ANY, "code", "%hu ", ops[i].code); >> + print_uint(PRINT_ANY, "jt", "%hhu ", ops[i].jt); >> + print_uint(PRINT_ANY, "jf", "%hhu ", ops[i].jf); > > Did you know that print_uint promotes the argument to unsigned int > then you are printing it with %hhu which expects only a u8. >
I did look at the print_hhu option and it seems really weird that you use "print_hhu(..., "%hhu", ...)" which is why I took the patch as is. There are existing examples of print_uint with '%hu' too. The print_ functions really should be renamed (print_uchar, print_ushort, etc).
